Home My Page Projects FusionForge
Summary Activity Forums Tracker Lists Tasks Docs Surveys News SCM Files Mediawiki Hudson oslc

[#219] Docman JS tree don't show folders without docs directly under them

Date:
2010-11-18 21:11
Priority:
3
State:
Closed
Submitted by:
Luis Daniel Ibáñez (libanez)
Assigned to:
Franck VILLAUME (nerville)
Target Release:
5.2
Found in Version:
5.0
Severity:
minor
Resolution:
Fixed
Summary:
Docman JS tree don't show folders without docs directly under them

Detailed description
When you create a document group that has subgroups which actually holds the documents, the parent (and consequently, all the childs) does not appear in the JavaScript document's tree in the "View Document" tab.

The problem is in /www/docman/index.php, function docman_recursive_display, that checks manually if the DocumentGroup has documents (and misses the check for subgroups), instead of using the hasDocument() method.

I'm attaching a patch which seems to works for me.

As an additional note, i suggest to default the second argument of the hasDocument() method to new DocumentFactory ($this->getGroup()).

Followups: Sort comments antichronologically

Message
Date: 2010-11-25 22:24
Sender: Franck VILLAUME

does it happen with branch 5.1 or trunk ?
Date: 2010-11-26 17:49
Sender: Luis Daniel Ibáñez

I don't know, but at least in trunk, this seems to be completely rewritten (Have not installed 5.1 yet, just a quick look to the scm browser)
Date: 2010-11-29 08:33
Sender: Franck VILLAUME

Docman has been reorganize in trunk and 5.1. But docman_recursive_display() is still used.
Nevertheless, I cannot reproduce your pb on both 5.1 and trunk.
Date: 2012-05-01 14:22
Sender: Franck VILLAUME

is it still valid in lastest trunk revision ?
Date: 2012-10-22 08:22
Sender: Franck VILLAUME

fixed in 5.2
please reopen if bug still occurs for you.

Attached Files:

Attachments:
Size Name Date By Download
2 KiBindex.php.diff2010-11-18 21:11libanezindex.php.diff

Changes:

Field Old Value Date By
status_idOpen2012-10-22 08:22nerville
close_dateNone2012-10-22 08:22nerville
assigned_tonone2012-10-22 08:22nerville
Target Release5.0.x2012-10-22 08:22nerville
ResolutionNone2012-10-22 08:22nerville
ResolutionAwaiting Response2011-11-17 17:58aljeux
Target Release5.0.32011-03-18 14:37nerville
File Added85: index.php.diff2010-11-18 21:11libanez